Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Collection view empty view not fill the vertical space #27464

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

Shalini-Ashokan
Copy link
Contributor

@Shalini-Ashokan Shalini-Ashokan commented Jan 30, 2025

Issue Details

The EmptyView of our CollectionView is not expanding to fill the available vertical space when displayed.

Root Cause

The EmptyView does not occupy the entire height and instead sizes itself based on the content. It fails to stretch and fill the available vertical space.

Description of Change

Modified the VerticalContentAlignment to Stretch instead of VerticalAlignment to fill the available vertical space.

Validated the behavior in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed

Fixes #18626

Output ScreenShot

Before After
VerticalSpace-issue VerticalSpace-Fix

Sorry, something went wrong.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 30, 2025
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 30, 2025
@Shalini-Ashokan Shalini-Ashokan marked this pull request as ready for review January 30, 2025 06:09
@Copilot Copilot bot review requested due to automatic review settings January 30, 2025 06:09
@Shalini-Ashokan Shalini-Ashokan requested a review from a team as a code owner January 30, 2025 06:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/Controls/src/Core/Platform/Windows/CollectionView/ItemsViewStyles.xaml: Language not supported

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Jan 30, 2025

/azp run

This comment was marked as outdated.

rmarinho
rmarinho previously approved these changes Jan 30, 2025

Verified

This commit was signed with the committer’s verified signature.
Darksonn Alice Ryhl
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Verified

This commit was signed with the committer’s verified signature.
Darksonn Alice Ryhl
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 86793f4 into dotnet:main Feb 12, 2025
124 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectionView's EmptyView Does Not Fill Vertical Space
4 participants