Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Fix for flaky UITests in CI that occasionally fail. #27453

Merged
merged 6 commits into from
Feb 25, 2025
Merged

[Testing] Fix for flaky UITests in CI that occasionally fail. #27453

merged 6 commits into from
Feb 25, 2025
+22 −24

Conversation

nivetha-nagalingam
Copy link
Contributor

@nivetha-nagalingam nivetha-nagalingam commented Jan 29, 2025 •
edited
Loading

Description of Change

This PR includes fixes for flaky UITest cases that were causing sporadic failures in the CI pipeline.

TestCases

  • Issue8761
  • Issue2354
  • Issue25514
  • Issue7393
  • Issue20535

Fixes #23064
Fixes #27272

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 29, 2025
@nivetha-nagalingam nivetha-nagalingam added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jan 29, 2025
@nivetha-nagalingam nivetha-nagalingam marked this pull request as ready for review January 29, 2025 15:59
@Copilot Copilot bot review requested due to automatic review settings January 29, 2025 15:59
@nivetha-nagalingam nivetha-nagalingam requested a review from a team as a code owner January 29, 2025 15:59
Copilot
Copilot AI reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25514.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8761.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/UITest.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.HostApp/Issues/Issue7393.cs:6

  • [nitpick] The string 'IsGrouped is true' should be 'IsGrouped="true"' for consistency with the original format.
[Issue(IssueTracker.Github, 7393, "[Bug] CollectionView problems and crashes with IsGrouped is true",

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Jan 30, 2025 •
edited by jfversluis
Loading

/azp run

@azure-pipelines Azure Pipelines

This comment was marked as off-topic.

Sign in to view
jsuarezruiz
jsuarezruiz previously requested changes Jan 30, 2025
View reviewed changes
jsuarezruiz
jsuarezruiz reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these tests are failing on Android:
image
Could be related with the VerifyInternetConnectivity method?

@nivetha-nagalingam
Copy link
Contributor Author

All these tests are failing on Android: image Could be related with the VerifyInternetConnectivity method?

@jsuarezruiz , Yes, these test failures are related to the VerifyInternetConnection method, and the fix for this issue has already been implemented in the PR #27284
For reference,
image (1)

@jsuarezruiz
Copy link
Contributor

All these tests are failing on Android: image Could be related with the VerifyInternetConnectivity method?

@jsuarezruiz , Yes, these test failures are related to the VerifyInternetConnection method, and the fix for this issue has already been implemented in the PR #27284 For reference, image (1)

So, the plan would be merge #27284 first and then rebase to fix this one, right?

@nivetha-nagalingam
Copy link
Contributor Author

nivetha-nagalingam commented Feb 5, 2025 •
edited
Loading

All these tests are failing on Android: image Could be related with the VerifyInternetConnectivity method?

@jsuarezruiz , Yes, these test failures are related to the VerifyInternetConnection method, and the fix for this issue has already been implemented in the PR #27284 For reference, image (1)

So, the plan would be merge #27284 first and then rebase to fix this one, right?

@jsuarezruiz , Yes, the plan is to first merge #27284 and then rebase here.

@nivetha-nagalingam
Copy link
Contributor Author

All these tests are failing on Android: image Could be related with the VerifyInternetConnectivity method?

@jsuarezruiz , Yes, these test failures are related to the VerifyInternetConnection method, and the fix for this issue has already been implemented in the PR #27284 For reference, image (1)

So, the plan would be merge #27284 first and then rebase to fix this one, right?

@jsuarezruiz , Yes, the plan is to first merge #27284 and then rebase here.

@jsuarezruiz , The planned PR #27284 has now been merged, and I have rebased my branch. Now we can trigger the CI for this.

@azure-pipelines Azure Pipelines

This comment was marked as off-topic.

Sign in to view
1 similar comment
@azure-pipelines Azure Pipelines

This comment was marked as off-topic.

Sign in to view
jfversluis
jfversluis requested changes Feb 23, 2025
View reviewed changes
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts please

@nivetha-nagalingam nivetha-nagalingam force-pushed the enabled-flaky-testcases-29 branch from e47450e to f819e73 Compare February 24, 2025 05:40
@nivetha-nagalingam
Copy link
Contributor Author

Resolve conflicts please

@jfversluis , I've resolved the conflicts and rebased the branch.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis dismissed jsuarezruiz’s stale review February 25, 2025 09:33

Feedback addressed

@jfversluis jfversluis merged commit d82f818 into dotnet:main Feb 25, 2025
123 checks passed
@jfversluis jfversluis added this to the .NET 9 SR5 milestone Feb 25, 2025
tj-devel709 pushed a commit that referenced this pull request Mar 3, 2025
@nivetha-nagalingam @tj-devel709
[Testing] Fix for flaky UITests in CI that occasionally fail. (#27453)
6eb7401 
* Verified the flaky test cases

* Verified the Flaky related test cases

* Addressed the Feedbacks

* Added the Issue20535

* Added the comment to the  Issue2354

* Update the snapshot for Windows platform
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz

Copilot code review Copilot

@jfversluis jfversluis

@PureWeen PureWeen

@tj-devel709 tj-devel709

Assignees
No one assigned
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
.NET 9 SR5
Development

Successfully merging this pull request may close these issues.

Reenable disabled flaky UI tests UITests broken for net9
3 participants
@nivetha-nagalingam @jsuarezruiz @jfversluis