Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] RemainingItemsThresholdReachedCommand of CarouselView is not triggered #25574

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Oct 29, 2024

Description of Change

The RemainingItemsThresholdReachedCommand is never triggered on Android when carousel view has the loop property set to true (a default value)

The cause of it is this overriden ItemCount property

Screenshot 2024-10-29 at 14 52 29 Screenshot 2024-10-29 at 14 50 29

I'm not sure if it is a desired behaviour or not, but on iOS and Windows this is not the case

Issues Fixed

Fixes #24571

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kubaflo kubaflo requested a review from a team as a code owner October 29, 2024 14:00
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 29, 2024
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android 🤖 area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Oct 29, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo
Copy link
Contributor Author

kubaflo commented Nov 15, 2024

Hi! @rmarinho what do you think?

@rmarinho rmarinho merged commit e917a9f into dotnet:main Dec 9, 2024
107 checks passed
@rmarinho rmarinho added this to the .NET 9 SR3 milestone Dec 9, 2024
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release! platform/android 🤖
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Android] RemainingItemsThresholdReachedCommand of CarouselView is not triggered
4 participants