Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggle for including sample content in template #25549

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Fix toggle for including sample content in template #25549

merged 6 commits into from
Oct 29, 2024

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Oct 28, 2024

Description of Change

This fixes the toggle for including sample content in the template. In #25419 some last-minute changes were made to not make the sample content show up by default, but that introduced a bug where you couldn't get the sample content to show up at all using Visual Studio.

With this change the sample content can optionally be included again in Visual Studio by using the checkbox and through the CLI by specifying either --sample-content or -sc.

Also the not used Empty switch was removed as well as the SampleContent variable which did not serve any additional purpose.

@jfversluis jfversluis added t/bug Something isn't working area-templates Project templates, Item Templates for Blazor and MAUI labels Oct 28, 2024
@jfversluis jfversluis added this to the .NET 9.0 GA milestone Oct 28, 2024
@jfversluis jfversluis requested a review from a team as a code owner October 28, 2024 09:46
@Redth
Copy link
Member

Redth commented Oct 28, 2024

/azp run

Redth
Redth previously approved these changes Oct 28, 2024
Redth and others added 3 commits October 28, 2024 14:28
@Redth Redth merged commit ad6f752 into main Oct 29, 2024
24 checks passed
@Redth Redth deleted the fix-template branch October 29, 2024 00:28
@Redth
Copy link
Member

Redth commented Oct 29, 2024

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11564984035

Redth added a commit that referenced this pull request Oct 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…#25564)

Backport of #25549 to release/9.0.1xx

/cc @Redth @jfversluis
@mrlacey
Copy link
Contributor

mrlacey commented Nov 2, 2024

Will this be available in VS before the GA release?

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI fixed-in-9.0.10 t/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants