Clear out prototype cell when changing ItemSource #24700
Merged
+73
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redth
previously approved these changes
Sep 10, 2024
rmarinho
previously approved these changes
Sep 10, 2024
PureWeen
changed the title
mattleibow
requested changes
Sep 11, 2024
src/Controls/tests/DeviceTests/Elements/ListView/ListViewTests.cs
Outdated
Show resolved
Hide resolved
Redth
approved these changes
Sep 11, 2024
mattleibow
approved these changes
Sep 11, 2024
rmarinho
approved these changes
Sep 11, 2024
|
4 tasks
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When converting ListView over to handler architecture we incorrectly commented out the code that would reset the prototype cell when the item source changed. This now causes issues with the prototype cell being reused and the datatemplate selector is being changed out
Issues Fixed
Fixes #20261