Add shared project for multi-project template when generated in Visual Studio #24095
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
the
area-templates
rmarinho
requested review from
Eilon and
mattleibow
and removed request for
jsuarezruiz and
PureWeen
mattleibow
approved these changes
Aug 10, 2024
samhouts
added
the
fixed-in-net8.0-nightly
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Because the shared project wasn't part of the
primaryOutputs it wasn't picked up by Visual Studio when generating the solution. This PR fixes that. Unfortunately, Visual Studio has its own engine for generating sln files, there is no test to be written for this.Additionally I added GUIDs to the template so that they are properly generated when new projects get created. Shouldn't be a big issue, but its the right thing to do.
Issues Fixed
Fixes #24089