[windows] fix memory leak in TabbedPage
#23281
Merged
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
added
the
memory-leak 💦
|
Update: I just reverted my changes related to the events, and it seems like maybe only Will know for sure when CI is working again. |
jonathanpeppers
force-pushed
the
WindowsTabbedPageLeaks
branch
2 times, most recently
from
2b9de8b to
75325f1
Compare
Context: dotnet#23166 This expands upon dotnet#23166 (iOS/Catalyst memory leaks for `TabbedPage`), fixing the same problem on Windows. I could reproduce the problem in `MemoryTests.cs`. I found the `NavigationViewItemViewModel.Data` property held the `ContentPage` that held onto the `TabbedPage`. I made the backing field a `WeakReference` and the test in `MemoryTests.cs` now passes on Windows.
jonathanpeppers
force-pushed
the
WindowsTabbedPageLeaks
branch
from
75325f1 to
8bd1226
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Jul 2, 2024
samhouts
added
fixed-in-8.0.70
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #23166
This expands upon #23166 (iOS/Catalyst memory leaks for
TabbedPage),fixing the same problem on Windows. I could reproduce the problem in
MemoryTests.cs.I found the
NavigationViewItemViewModel.Dataproperty held theContentPagethat held onto theTabbedPage. I made the backing fielda
WeakReferenceand the test inMemoryTests.csnow passes on Windows.