[main] Update dependencies from dotnet/arcade #6703

dotnet-maestro · 2023-05-22T12:36:40Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 97926d79-6b8b-4d32-c8db-08d9d479971c
Build: 20231228.1
Date Produced: December 28, 2023 10:38:38 AM UTC
Commit: 9e5fd26c0d1a187dfa08242d83e341634d4b1b07
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23265.1 to 9.0.0-beta.23628.1
- Microsoft.DotNet.Build.Tasks.Feed: from 8.0.0-beta.23265.1 to 9.0.0-beta.23628.1
- Microsoft.DotNet.Helix.Sdk: from 8.0.0-beta.23265.1 to 9.0.0-beta.23628.1
- Microsoft.DotNet.SignTool: from 8.0.0-beta.23265.1 to 9.0.0-beta.23628.1
- Microsoft.DotNet.SwaggerGenerator.MSBuild: from 8.0.0-beta.23265.1 to 9.0.0-beta.23628.1
- Microsoft.DotNet.XliffTasks: from 1.0.0-beta.21376.1 to 9.0.0-beta.23628.1
- Microsoft.DotNet.XUnitExtensions: from 8.0.0-beta.23265.1 to 9.0.0-beta.23628.1

…519.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23269.2

codecov · 2023-05-25T22:45:07Z

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d3c3127) 68.80% compared to head (501826e) 68.80%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6703   +/-   ##
=======================================
  Coverage   68.80%   68.80%           
=======================================
  Files        1249     1249           
  Lines      249433   249436    +3     
  Branches    25509    25468   -41     
=======================================
+ Hits       171615   171633   +18     
- Misses      71209    71212    +3     
+ Partials     6609     6591   -18

Flag	Coverage Δ
Debug	`68.80% <47.82%> (+<0.01%)`	⬆️
production	`63.26% <ø> (+<0.01%)`	⬆️
test	`88.49% <47.82%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs	`100.00% <100.00%> (ø)`
...ata.Analysis.Tests/DataFrameJoinExtensionsTests.cs	`100.00% <100.00%> (ø)`
.../Microsoft.ML.AutoML.Tests/ColumnInferenceTests.cs	`96.29% <100.00%> (ø)`
...t.ML.AutoML.Tests/SuggestedPipelineBuilderTests.cs	`100.00% <100.00%> (ø)`
test/Microsoft.ML.FSharp.Tests/SmokeTests.fs	`87.23% <ø> (ø)`
...t/Microsoft.ML.PerformanceTests/Harness/Configs.cs	`0.00% <ø> (ø)`
...stFramework/Attributes/BenchmarkTheoryAttribute.cs	`100.00% <ø> (ø)`
test/Microsoft.ML.TestFramework/GlobalBase.cs	`33.33% <100.00%> (ø)`
test/Microsoft.ML.TestFramework/TestCommandBase.cs	`39.45% <100.00%> (+0.04%)`	⬆️
...icrosoft.ML.TestFramework/DataPipe/TestDataPipe.cs	`91.06% <0.00%> (ø)`
... and 5 more

... and 15 files with indirect coverage changes

…529.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23279.1

michaelgsharp · 2023-06-01T19:20:09Z

/azp run

azure-pipelines · 2023-06-01T19:20:20Z

Azure Pipelines successfully started running 2 pipeline(s).

…602.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23302.3

…609.8 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23309.8

…616.6 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23316.6

…622.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23322.2

…630.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23330.1

…710.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23360.1

…714.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23364.2

…721.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23371.1

…728.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23378.2

…804.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23404.2

…811.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23411.1

…819.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23419.1

…825.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23425.2

michaelgsharp · 2023-09-01T22:37:06Z

/azp run

azure-pipelines · 2023-09-01T22:37:17Z

Azure Pipelines successfully started running 2 pipeline(s).

…901.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23451.1

…913.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 8.0.0-beta.23463.1

…008.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23508.1

…010.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23510.4

…018.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23518.2

.vsts-dotnet-ci.yml

ericstj · 2023-12-21T22:02:28Z

Getting close! The ARM64 failures are both #6921.

@michaelgsharp - looks like the OSX failure in TestSaveAndLoadDoubleTreeFeaturizer is different

Assert.Equal() Failure: Values are not within 5 decimal places
Expected: 0.19011 (rounded from 0.1901149994134903)
Actual:   0.19012000000000001 (rounded from 0.19011500015854835)

It's funny, the actual difference between these two numbers is 0.00000000074505805, or 7.45 x 10^-10, but that's enough to make it round differently at 5 decimal places 😆 I wonder if we should use a different assert?

ericstj · 2023-12-21T22:12:55Z

Turns out there's actually an assert that does that; https://github.com/xunit/assert.xunit/blob/6d9024665f1b67714311b38b72054fbad9d9972c/EqualityAsserts.cs#L342

Might be good to adopt this in our double comparisons since it would be less sensitive to differences when expected value is close to a rounding threshold.

ericstj · 2023-12-22T20:18:57Z

/azp run

azure-pipelines · 2023-12-22T20:19:09Z

Azure Pipelines successfully started running 2 pipeline(s).

.vsts-dotnet-ci.yml

test/Microsoft.ML.Tests/Data/github-issues-train.tsv

test/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs

…a34d-4ff1-bd23-11be82f3618c

This reverts commit ab0d41e.

…221.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23621.2

…228.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23265.1 -> To Version 9.0.0-beta.23628.1

ericstj · 2024-01-02T22:50:33Z

Wow, green build. Should we merge it @michaelgsharp?

michaelgsharp

LGTM

ericstj · 2024-01-03T00:51:32Z

So this introduced a build break where the NoWarn for NETSDK1206 doesn't always apply. #6935 is fixing that.

dotnet-maestro bot and others added 2 commits May 22, 2023 12:36

Add dotnet8 nuget feed

f2e4581

michaelgsharp approved these changes Jun 1, 2023

View reviewed changes

dotnet-maestro bot added 13 commits June 5, 2023 12:36

dotnet-maestro bot added 8 commits September 4, 2023 12:27

ericstj added 3 commits December 19, 2023 13:13

Fix packaging step

51b0cce

Try including stdint.h to fix missing uint8_t on centos

c0cbaa9

Update Centos test queue

5fa79bc

ericstj reviewed Dec 19, 2023

View reviewed changes

.vsts-dotnet-ci.yml Outdated Show resolved Hide resolved

ericstj added 2 commits December 19, 2023 17:24

Attempt to use runtime centos-stream8-helix container for tests

f28adef

Use centos-stream8-mlnet-helix container for testing

e585487

build-analysis bot mentioned this pull request Dec 21, 2023

Failed assert in ImplVec<T>.Fetch on Arm #6921

Closed

ericstj mentioned this pull request Dec 21, 2023

Make double assertions compare with tolerance instead of precision #6923

Merged

ericstj requested a review from michaelgsharp December 22, 2023 20:40

ericstj reviewed Dec 22, 2023

View reviewed changes

.vsts-dotnet-ci.yml Show resolved Hide resolved

ericstj reviewed Dec 22, 2023

View reviewed changes

test/Microsoft.ML.Tests/Data/github-issues-train.tsv Outdated Show resolved Hide resolved

ericstj reviewed Dec 22, 2023

View reviewed changes

test/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs Outdated Show resolved Hide resolved

ericstj and others added 7 commits December 22, 2023 14:18

Undo changes to test data

4a404f3

Make NETFRAMEWORK ifdef versionless

75b3706

Merge remote-tracking branch 'upstream/main' into darc-main-4fc19a23-…

c47e345

…a34d-4ff1-bd23-11be82f3618c

Switch back to centos7 for testing

ab0d41e

Revert "Switch back to centos7 for testing"

56511ac

This reverts commit ab0d41e.

michaelgsharp approved these changes Jan 2, 2024

View reviewed changes

ericstj merged commit f625080 into main Jan 2, 2024
25 checks passed

dotnet-maestro bot deleted the darc-main-4fc19a23-a34d-4ff1-bd23-11be82f3618c branch January 2, 2024 23:50

ericstj mentioned this pull request Jan 4, 2024

[release/3.0] Update dependencies from dotnet/arcade #6938

Merged

github-actions bot locked and limited conversation to collaborators Feb 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/arcade #6703

[main] Update dependencies from dotnet/arcade #6703

dotnet-maestro bot commented May 22, 2023 •

edited

codecov bot commented May 25, 2023 •

edited

michaelgsharp commented Jun 1, 2023

azure-pipelines bot commented Jun 1, 2023

michaelgsharp commented Sep 1, 2023

azure-pipelines bot commented Sep 1, 2023

ericstj commented Dec 21, 2023

ericstj commented Dec 21, 2023

ericstj commented Dec 22, 2023

azure-pipelines bot commented Dec 22, 2023

ericstj commented Jan 2, 2024

michaelgsharp left a comment

ericstj commented Jan 3, 2024

[main] Update dependencies from dotnet/arcade #6703

[main] Update dependencies from dotnet/arcade #6703

Conversation

dotnet-maestro bot commented May 22, 2023 • edited

From https://github.com/dotnet/arcade

codecov bot commented May 25, 2023 • edited

Codecov Report

michaelgsharp commented Jun 1, 2023

azure-pipelines bot commented Jun 1, 2023

michaelgsharp commented Sep 1, 2023

azure-pipelines bot commented Sep 1, 2023

ericstj commented Dec 21, 2023

ericstj commented Dec 21, 2023

ericstj commented Dec 22, 2023

azure-pipelines bot commented Dec 22, 2023

ericstj commented Jan 2, 2024

michaelgsharp left a comment

Choose a reason for hiding this comment

ericstj commented Jan 3, 2024

dotnet-maestro bot commented May 22, 2023 •

edited

codecov bot commented May 25, 2023 •

edited