Update 6.0 Test Baselines #19798
Update 6.0 Test Baselines #19798
Conversation
|
@dotnet/source-build-internal - soft ping |
There was a problem hiding this comment.
It seems like we should investigate why these leaks are occurring and fix them.
There was a problem hiding this comment.
Based on dotnet/source-build#2997, it seems like Microsoft.DotNet.Arcade.Sdk and Microsoft.DotNet.Build.Tasks.Packaging are non-shipping packages and shouldn't be considered for poison leaks. This infra was added/fixed in 8.0 but the poisoning of non-shipping packages remains in 6.0 (hence the newly reported leaks for these two packages). On the bright side, these packages account for a good portion of these new poison leaks.
The remaining packages with new leaks are Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.PackageTesting, and Microsoft.DotNet.SourceBuild.Tasks.
@NikolaMilosavljevic - I went through old issues with poison leaks, and it looks like you did a lot of the work on the poison infra for excluding non-shipping packages. Can you explain how to determine if a package is non-shipping and also verify my thinking that poison leaks related to Microsoft.DotNet.Arcade.Sdk and Microsoft.DotNet.Build.Tasks.Packaging should be ignored?
There was a problem hiding this comment.
I think I figured it out. It looks like anything produced by Arcade is marked with the IsShipping=false property. This includes the following packages:
Microsoft.DotNet.Arcade.SdkMicrosoft.DotNet.Build.Tasks.PackagingMicrosoft.DotNet.Build.Tasks.TargetFramework.SdkMicrosoft.DotNet.Build.Tasks.WorkloadMicrosoft.DotNet.PackageTestingMicrosoft.DotNet.SourceBuild.Tasks
This means that all the packages appearing in the poison report can be added to the baseline.
Updates the SDK diff baseline and the poison usage report with results from this test run (internal Microsoft link)