Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine source build CI leg #15765

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Conversation

MichaelSimons
Copy link
Member

Port #14417 to main.

This didn't flow automatically because of the VMR and pipeline infrastructure changes.

@@ -47,7 +51,7 @@ public void VerifyVersionFile()
string sdkVersion = versionLines[1];

// Find the expected SDK version by getting it from the SDK tarball
ExtractFileFromTarball(Config.SdkTarballPath, "./sdk/*/.version", outputDir);
Utilities.ExtractFileFromTarball(Config.SdkTarballPath, "./sdk/*/.version", outputDir);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is required because Alpine doesn't support the --wildcards option like the other distros.

@MichaelSimons
Copy link
Member Author

cc @omajid

@MichaelSimons
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

@MichaelSimons MichaelSimons force-pushed the alpine-ci branch 2 times, most recently from b2a8e80 to 9eb49ea Compare March 10, 2023 21:55
@MichaelSimons
Copy link
Member Author

This PR is blocked because of prebuilts. In order to build offline we need Microsoft.NETCore.App.Host.linux-musl-x64 with version (= 7.0.2). Because the Alpine CI leg was added after 7.0.2, we don't have a convenient way to produce this. Because of that, this PR is blocked until the prebuilt is removed or the 8.0 SDK updates it's known framework reference for 7.0 to a newer version so that we can grab it from the Microsoft CI leg.

@MichaelSimons MichaelSimons marked this pull request as ready for review June 2, 2023 15:02
@MichaelSimons MichaelSimons requested a review from a team as a code owner June 2, 2023 15:02
@MichaelSimons
Copy link
Member Author

This is now ready for review.

FYI @ayakael

@@ -84,6 +88,27 @@ stages:
withPreviousSDK: false # 🚫

- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:

# CI - Stage 1 x64 legs ------------------------------------
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for feedback on these header style comments. I am attempting to improve the readability by making it easier to quickly differentiate the various types of legs.

@MichaelSimons MichaelSimons enabled auto-merge (squash) June 2, 2023 19:20
@MichaelSimons MichaelSimons enabled auto-merge (squash) June 2, 2023 19:22
@MichaelSimons MichaelSimons merged commit e65d042 into dotnet:main Jun 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants