Remove workaround for https://github.com/dotnet/source-build/issues/3121 #15254
Conversation
| @@ -119,16 +118,6 @@ | |||
| <WriteLinesToFile File="$(CompletedSemaphorePath)BuildXPlatTasks.complete" Overwrite="true" /> | |||
| </Target> | |||
|
|
|||
| <!-- TODO: Remove this when the .NET 8 artifacts tarball no longer includes MicrosoftAspNetCoreAppRuntimePackageVersion --> | |||
There was a problem hiding this comment.
I don't think this can be removed until we update the previous source build artifacts to be an 8.0 version. This property is still defined because we are using a 7.0 version of PSB.
There was a problem hiding this comment.
Yeah you may be right. I think this is the key comment here: dotnet/source-build#3121 (comment)
dotnet/installer#14938 implements it. It combines my patch with @crummel's PR. For 8.0 we should be able to change back to the original property name (
MicrosoftAspNetCoreAppRuntimePackageVersion) when the Artifacts tarball no longer includes this name.
I'll check it out.
There was a problem hiding this comment.
FYI I updated PSB in #15324 and merged the changes in here to see if it passes CI now.
|
I guess this was already removed with the PVP work in #15267. |
dotnet/source-build#3121 was closed