Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MetadataExtractor & MetricsReports in Microsoft.Extensions.AuditReports create directories [Same as ComplianceReport] #5919

Conversation

IbrahimMNada
Copy link
Contributor

@IbrahimMNada IbrahimMNada commented Feb 18, 2025

When working with Microsoft.Extensions.AuditReports package, I noticed some inconsistency while creating reports on the file system.

ComplianceReports Creates directories if they were not found, while MetadataExtractor & MetricsReports Do not.
This pull request fix this inconsistency and enabling them all to create directory when needed.

Furthermore , it fixes some string naming bug & tweak unit test case Should_UseProjectDir_WhenOutputPathIsRelative in the Microsoft.Gen.MetadataExtractor.Unit.Tests namespace.

this Asp.net repository holds a sample https://github.com/IbrahimMNada/MetaDataExtractorTesting
of Microsoft.Extensions.AuditReports working with locally packed packages for testing

and here is a screen shot of the unit tests :

image
Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Gen.MetadataExtractor 57 70

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954986&view=codecoverage-tab

@IbrahimMNada IbrahimMNada changed the title Make Audit.Reports create directories when [Same as ComplianceReport] Make Microsoft.Extensions.AuditReports create directories when [Same as ComplianceReport] Feb 18, 2025
@IbrahimMNada IbrahimMNada changed the title Make Microsoft.Extensions.AuditReports create directories when [Same as ComplianceReport] Make MetadataExtractor & MetricsReports in Microsoft.Extensions.AuditReports create directories [Same as ComplianceReport] Feb 18, 2025
Copy link
Contributor

@dariusclay dariusclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants