Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-Build TypeScript packages before CI builds #5907

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Pre-Build TypeScript packages before CI builds #5907

merged 4 commits into from
Feb 14, 2025
+9 −0

Conversation

peterwald
Copy link
Member

@peterwald peterwald commented Feb 14, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #5901

Microsoft Reviewers: Open in CodeFlow

@peterwald peterwald requested a review from a team as a code owner February 14, 2025 22:10
@shyamnamboodiripad shyamnamboodiripad enabled auto-merge (squash) February 14, 2025 23:15
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.OpenAI Line 77 67.92 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 49.8 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Line 88 72.06 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Branch 88 64.8 🔻
Microsoft.Extensions.AI.Evaluation Line 88 58.67 🔻
Microsoft.Extensions.AI.Evaluation Branch 88 56.67 🔻
Microsoft.Extensions.AI.Evaluation.Console Line 88 8.26 🔻
Microsoft.Extensions.AI.Evaluation.Console Branch 88 17.07 🔻
Microsoft.Extensions.AI.Evaluation.Quality Line 88 7.57 🔻
Microsoft.Extensions.AI.Evaluation.Quality Branch 88 16.42 🔻
Microsoft.Extensions.AI.AzureAIInference Line 91 90.09 🔻
Microsoft.Extensions.AI.AzureAIInference Branch 91 86.76 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Extensions.AI.Abstractions Branch 83 82.85 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.Caching.Hybrid 86 87

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=953181&view=codecoverage-tab

@shyamnamboodiripad shyamnamboodiripad merged commit 1146e90 into dotnet:main Feb 14, 2025
6 checks passed
@peterwald peterwald deleted the pre-build branch February 18, 2025 15:42
@rnelson rnelson mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie

@shyamnamboodiripad shyamnamboodiripad

Assignees

@peterwald peterwald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI build failing after M.E.AI.Evaluations merging
4 participants
@peterwald @dotnet-comment-bot @RussKie @shyamnamboodiripad