Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an environment variable for configuring Ollama integration tests #5851

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Feb 6, 2025

I very often catch myself accidentally committing changes to Ollama's integration test helper. This changes the helper so that the endpoint is detected from the environment.

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis eiriktsarpalis enabled auto-merge (squash) February 6, 2025 19:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 82.77 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=943094&view=codecoverage-tab

@eiriktsarpalis eiriktsarpalis merged commit 19fd307 into dotnet:main Feb 6, 2025
6 checks passed
@eiriktsarpalis eiriktsarpalis deleted the ollama-integration-env branch February 6, 2025 20:44
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ai Microsoft.Extensions.AI libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants