-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tailwind and NPM dependency from chat template #5846
Conversation
...ates/Microsoft.Extensions.AI.Templates/src/ChatWithCustomData/.template.config/template.json
Outdated
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=940194&view=codecoverage-tab |
...ates/src/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatInput.razor.css
Outdated
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Outdated
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Show resolved
Hide resolved
...rc/ChatWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageList.razor.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
...rosoft.Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent - thanks very much! What you've done with the CSS looks perfect.
I added some minor suggestions about using CSS shorthand syntax in a few places. I'm pretty sure none of them will change the resulting styles, but it's possible I could have a typo in there so please let me know if anything looks wrong.
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatInput.razor.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageList.razor.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=941270&view=codecoverage-tab |
This PR:
wwwroot
folderFixes https://github.com/dotnet/ai-private-planning/issues/272
Fixes https://github.com/dotnet/ai-private-planning/issues/273
Microsoft Reviewers: Open in CodeFlow