Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tailwind and NPM dependency from chat template #5846

Merged
merged 18 commits into from
Feb 5, 2025

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Feb 4, 2025

This PR:

  1. Removes tailwind classes from Razor components and replaces them with CSS classes defined in the project
  2. Removes NPM as a dependency and instead includes external dependencies directly in the wwwroot folder

Fixes https://github.com/dotnet/ai-private-planning/issues/272
Fixes https://github.com/dotnet/ai-private-planning/issues/273

Microsoft Reviewers: Open in CodeFlow

…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 77.82 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=940194&view=codecoverage-tab

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks very much! What you've done with the CSS looks perfect.

I added some minor suggestions about using CSS shorthand syntax in a few places. I'm pretty sure none of them will change the resulting styles, but it's possible I could have a typo in there so please let me know if anything looks wrong.

MackinnonBuck and others added 8 commits February 5, 2025 09:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatInput.razor.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageList.razor.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
MackinnonBuck and others added 4 commits February 5, 2025 09:10
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@MackinnonBuck MackinnonBuck enabled auto-merge (squash) February 5, 2025 17:34
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.Caching.Hybrid 86 87
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=941270&view=codecoverage-tab

@MackinnonBuck MackinnonBuck merged commit 3640389 into main Feb 5, 2025
6 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/ai-template-remove-npm branch February 5, 2025 18:13
@jeffhandley jeffhandley added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ai-templates Microsoft.Extensions.AI.Templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants