Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When creating the "missing column" error message, use the same (case insensitive) column name comparer used in field value retrieval #33749

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

When creating the "missing column" error message, use the same (case insensitive) column name comparer used in field value retrieval #33749

wants to merge 1 commit into from
+36 −1

Conversation

simonmckenzie
Copy link

@simonmckenzie simonmckenzie commented May 18, 2024 •
edited

Issue #33748

This addresses an issue where a column with different casing to the entity's field would be selected as the "first missing column" when assembling the error message. The field name lookup's key comparer is case insensitive, and using it here ensures that all column name comparisons will use the same comparer.

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@simonmckenzie
When creating the "missing column" error message, use the same (case …
c9c4167 
…insensitive) column name comparer used in field value retrieval

- Update the existing code that finds the "first missing column" to use the `_fieldNameLookup`, as its key comparer is case insensitive.

Fixes dotnet#33748
@simonmckenzie simonmckenzie force-pushed the fix/use-consistent-column-comparison-when-identifying-missing-columns branch from e1283a4 to c9c4167 Compare May 18, 2024 01:58
@simonmckenzie simonmckenzie changed the title Use the field name lookup when matching column names When creating the "missing column" error message, use the same (case insensitive) column name comparer used in field value retrieval May 18, 2024
@simonmckenzie
Copy link
Author

simonmckenzie commented May 18, 2024 via email

@roji
Copy link
Member

roji commented May 27, 2024

Note: this PR is waiting on a design discussion on #33748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

@roji roji Awaiting requested review from roji

At least 1 approving review is required to merge this pull request.

Assignees

@roji roji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonmckenzie @roji