Add precompiled query generation to the dbcontext optimize command #33747
+878
−246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue33103
branch
2 times, most recently
from
881f8e9
to
b840cc6
Compare
AndriySvyryd
commented
May 21, 2024
AndriySvyryd
force-pushed
the
Issue33103
branch
4 times, most recently
from
620a708
to
0eaf687
Compare
AndriySvyryd
commented
May 24, 2024
| Condition="'$(PublishAot)'=='true'" | ||
| Properties="Configuration=$(Configuration);Platform=$(Platform);EFOptimizeContext=false;PublishAot=false" /> | ||
| Properties="Configuration=$(Configuration);Platform=$(Platform);PublishAot=false;_EFGenerationStage=$(_EFGenerationStage)" /> |
There was a problem hiding this comment.
Do we need to always pass Configuration and Platform? Should we pass other properties?
AndriySvyryd
commented
May 24, 2024
| This target has the same Inputs and Outputs as CoreCompile to run only if CoreCompile isn't going to be skipped --> | ||
| <Target Name="_EFPrepareForCompile" | ||
| DependsOnTargets="_EFProcessGeneratedFiles" | ||
| Condition="'$(EFOptimizeContext)'=='true'" | ||
| Condition="'$(_EFGenerationStage)'==''" | ||
| Inputs="$(MSBuildAllProjects); |
There was a problem hiding this comment.
Is there a better way of determining whether CoreCompile is going to be skipped other than duplicating its inputs and outputs?
AndriySvyryd
commented
May 24, 2024
|
|
||
| MSBuildLocator.RegisterDefaults(); | ||
| // TODO: pass through properties | ||
| var workspace = MSBuildWorkspace.Create(); |
There was a problem hiding this comment.
What properties should we pass through from the MsBuild invocation?
AndriySvyryd
force-pushed
the
Issue33103
branch
2 times, most recently
from
3616c0f
to
3d181c1
Compare
…unless a single one is specified Fixes #33558
|
Just to say that this is on my list to review... Will work up to it in the next few days. |
Ok. Just note that the longer you take to review the more code will need to be reviewed 😉 |
|
That's a pretty effective way to speed up a code review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds publish integration for precompiled queries and combines it with compiled model generation.
For the compiled model and precompiled queries to be generated when publishing with NativeAOT the only action needed is to reference
Microsoft.EntityFrameworkCore.Tasksfrom all projects containing aDbContextor a query.For solutions where specifying the startup project is necessary,
EFStartupProjectshould be set.EFOptimizeContextcan be set totrueto enable code generation outside of NativeAOT.EFScaffoldModelStageandEFPrecompileQueriesStagecan be set to eitherpublishorbuildto control at what stage will the code be generated. Any other value will disable the corresponding generation (in case the code is generated manually usingdotnet ef dbcontext optimize)If there's more than one context and
DbContextNameis not set, then the compiled model will be generated for all of them.EFTargetNamespaceandEFOutputDircan be used to further fine-tune the generation.Fixes #33103
Fixes #33558