Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component governance] Update Azure.Identity dependency #32108

Closed
wants to merge 2 commits into from

Conversation

javiercn
Copy link
Member

Updates the Azure.Identity version.

@javiercn javiercn requested a review from a team October 20, 2023 15:55
@roji
Copy link
Member

roji commented Oct 20, 2023

FYI I know SqlClient are working to update the dependency on its side, and we don't usually take direct dependencies on their transitive dependencies. But it may be justified in this case...

@ajcvickers
Copy link
Member

ajcvickers commented Oct 24, 2023

@javiercn What are the circumstances here that mean we should add an explicit reference to the transient rather than updating the direct dependency? (If the direct dependency isn't updated yet, then that's something that needs to be done on SqlClient so that it can flow through to here.)

@amcasey
Copy link
Member

amcasey commented Oct 24, 2023

I'm not a nuget dependency expert, but it looks like 5.1.1 is the newest version of SqlClient and it depends on Azure.Identity 1.7.0 (or newer?).

@amcasey
Copy link
Member

amcasey commented Oct 24, 2023

But: dotnet/SqlClient#2189

@ajcvickers
Copy link
Member

Right. SqlClient needs to ship a new package, then we can depend on that.

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 25, 2023

And it needs to be a LTS version I guess?

@ajcvickers
Copy link
Member

Fixed by #32187

@ajcvickers ajcvickers closed this Oct 30, 2023
@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 30, 2023

@ajcvickers how fixed? 5.1.2 does not include an update..

@roji roji reopened this Oct 30, 2023
@ajcvickers
Copy link
Member

There is nothing to track here. We will not be taking a direct dependency on Azure.Identity. This was discussed in Tactics.

@ajcvickers ajcvickers closed this Nov 13, 2023
@AndriySvyryd AndriySvyryd deleted the javiercn/update-azure-identity-dependency branch December 6, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants