Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix global.json lookup explanation #40953

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix global.json lookup explanation #40953

merged 1 commit into from
May 21, 2024

Conversation

paulloz
Copy link
Contributor

@paulloz paulloz commented May 16, 2024 •
edited by github-actions bot

Summary

Two sentences were contradicting each other. I simply removed the incorrect one, and brought a small precision from the page about global.json.

Internal previews

馃搫 File 馃敆 Preview link
docs/core/versions/selection.md Select the .NET version to use

@paulloz paulloz requested a review from a team as a code owner May 16, 2024 07:25
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 16, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label May 16, 2024
gewarren
gewarren approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulloz

@gewarren gewarren merged commit adf5f62 into dotnet:main May 21, 2024
11 checks passed
@paulloz paulloz deleted the fix-globaljson-lookup-explanation branch May 22, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

Contradictory explanation of how global.json is searched for
3 participants
@paulloz @gewarren @dotnet-bot