[release/6.0] source-build: support building aspnetcore using non-portable runtime packages (backport #43937)

[ayakael]

source-build: support building aspnetcore using non-portable runtime packages (backport #43937)

Description

Backport of #43937

Per @tmds

Currently source-build performs 'runtime-portable' build that produces 'linux-{arch}' packages that are used when building ASP.NET Core.

With this change, we can use the non-portable packages that are produced by the source-build 'runtime' build, and eliminate the 'runtime-portable' build.

Customer impact

Reduces build time with source-build significantly due to not needing the building of portable runtime.

Regression?

• Yes
• No

[If yes, specify the version the behavior has regressed from]

Risk

• High
• Medium
• Low

Only activates when PortableBuild=false. As it defaults to true, this change should not affect any other customers than distro maintainers.

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

---

[ghost]

Thanks for your PR, @ayakael. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[ghost]

Hi @ayakael. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[dougbu]

Backport of #43937

Please describe any changes between that PR and this. Everything feels familiar but I may be missing something.

Separately, have you tested this branch with /p:TargetRuntimeIdentifier={something} /p:PortableBuild=false❔

[ghost]

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

[ayakael]

Backport of #43937

Please describe any changes between that PR and this. Everything feels familiar but I may be missing something.

Separately, have you tested this branch with /p:TargetRuntimeIdentifier={something} /p:PortableBuild=falsegrey_question

I essentially applied the patch as it was in the backport, manually cleaning up whatever didn't apply cleanly due to code not existing yet. In this case, the following was cut due to that code not existing yet:

diff --git a/src/aspnetcore/eng/tools/GenerateFiles/Directory.Build.targets.in b/src/aspnetcore/eng/tools/GenerateFiles/Directory.Build.targets.in
index 0100971de43d..e97a6485d5b9 100644
--- a/src/aspnetcore/eng/tools/GenerateFiles/Directory.Build.targets.in
+++ b/src/aspnetcore/eng/tools/GenerateFiles/Directory.Build.targets.in
@@ -56,22 +56,22 @@ 
     <KnownAppHostPack Update="Microsoft.NETCore.App">
       <AppHostPackVersion
         Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</AppHostPackVersion>
-      <AppHostRuntimeIdentifiers Condition=" '$(PortableBuild)' != 'true' ">$(TargetRuntimeIdentifier)</AppHostRuntimeIdentifiers>
+      <AppHostRuntimeIdentifiers Condition=" '$(PortableBuild)' == 'false' ">$(TargetRuntimeIdentifier)</AppHostRuntimeIdentifiers>
     </KnownAppHostPack>
 
     <KnownRuntimePack Update="Microsoft.NETCore.App">
       <LatestRuntimeFrameworkVersion
         Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</LatestRuntimeFrameworkVersion>
-      <AppHostRuntimeIdentifiers Condition=" '$(PortableBuild)' != 'true' ">$(TargetRuntimeIdentifier)</AppHostRuntimeIdentifiers>
+      <AppHostRuntimeIdentifiers Condition=" '$(PortableBuild)' == 'false' ">$(TargetRuntimeIdentifier)</AppHostRuntimeIdentifiers>
     </KnownRuntimePack>

[ayakael]

/p:TargetRuntimeIdentifier={something}

As far as testing is concerned, all checks passes here with these parameters set: dotnet/installer#14816.

[dougbu]

Sounds good. We'll merge when the branches open next.