New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | Fix DateTimeOffset size in TdsValueSetter.cs class file. #2453
Fix | Fix DateTimeOffset size in TdsValueSetter.cs class file. #2453
Conversation
@saitama951 This change would be in contrast with PR #2170. Could you verify this change on your end, as we don't have big endian systems to test, please? |
@DavoudEshtehari I ran the tests. All the test cases passed.
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2453 +/- ##
==========================================
+ Coverage 66.85% 72.72% +5.86%
==========================================
Files 304 313 +9
Lines 61576 61738 +162
==========================================
+ Hits 41168 44897 +3729
+ Misses 20408 16841 -3567
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UdtDateTimeOffsetTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UdtDateTimeOffsetTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DateTimeOffsetList.cs
Outdated
Show resolved
Hide resolved
…ays what they have been before.
This PR fixes issue #2423.