Regression | Revert PR #2281 SNIProxy code change #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Engel
reviewed
Mar 8, 2024
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <dengel1012@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
- Coverage 72.69% 72.62% -0.07%
==========================================
Files 310 310
Lines 61885 61885
==========================================
- Hits 44987 44947 -40
- Misses 16898 16938 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
David-Engel
approved these changes
Mar 8, 2024
esbenbjerre
approved these changes
Mar 11, 2024
DavoudEshtehari
approved these changes
Mar 11, 2024
|
Can you link the related issues for the record? |
|
Wonder if it would be possible to add a test to prevent this from regressing again? |
I was thinking the same. I compared it with SDS and will start by adding some tests. However, I need to understand the reason behind #2394 first. It seems the underlying cause of that issue might be a bit different. |
arellegue
approved these changes
Mar 12, 2024
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/InstanceNameTest/InstanceNameTest.cs
Show resolved
Hide resolved
DavoudEshtehari
added a commit
that referenced
this pull request
Mar 28, 2024
DavoudEshtehari
added a commit
that referenced
this pull request
Mar 28, 2024
DavoudEshtehari
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts back the code change from #2281 to address regression in v5.2.0