Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test | Adjust tests to read IsAzureSynapse value from database #2367

Merged
merged 6 commits into from Feb 26, 2024
Merged

Test | Adjust tests to read IsAzureSynapse value from database #2367

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c2af98
Adjusting tests to read IsAzureSynapse value from database
JRahnama Feb 23, 2024
80b172e
commit
JRahnama Feb 23, 2024
8c9642a
adjusting enginedition variable name
JRahnama Feb 23, 2024
f54ede6
replacing string comparison with int
JRahnama Feb 23, 2024
d0248fd
spelling correction
JRahnama Feb 23, 2024
3ca9e3d
updating buildGuide
JRahnama Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
45 changes: 37 additions & 8 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
View file
Open in desktop
JRahnama marked this conversation as resolved.
Show resolved Hide resolved
Expand Up @@ -51,7 +51,7 @@ public static class DataTestUtility
public static readonly bool TracingEnabled = false;
public static readonly bool SupportsIntegratedSecurity = false;
public static readonly bool UseManagedSNIOnWindows = false;
public static readonly bool IsAzureSynapse = false;

public static Uri AKVBaseUri = null;
public static readonly string PowerShellPath = null;
public static string FileStreamDirectory = null;
Expand Down Expand Up @@ -95,13 +95,35 @@ public static class DataTestUtility
private static string s_sQLServerVersion = string.Empty;
private static bool s_isTDS8Supported;

//SQL Server EnginEditionId
JRahnama marked this conversation as resolved.
Show resolved Hide resolved
private static string s_sqlServerEndinEditionId;
JRahnama marked this conversation as resolved.
Show resolved Hide resolved

private static string SQLServerEnginEditionId()
JRahnama marked this conversation as resolved.
Show resolved Hide resolved
{

if (!string.IsNullOrEmpty(TCPConnectionString))
{
s_sqlServerEndinEditionId ??= GetSqlServerProperty(TCPConnectionString, "EngineEdition");
}
return s_sqlServerEndinEditionId;
}
// Azure Synapse EnginEditionId == 6
// More could be read at https://learn.microsoft.com/en-us/sql/t-sql/functions/serverproperty-transact-sql?view=sql-server-ver16#propertyname
public static bool IsAzureSynapse
{
get
{
return string.Equals("6", SQLServerEnginEditionId().Trim());
}
}

public static string SQLServerVersion
{
get
{
if (!string.IsNullOrEmpty(TCPConnectionString))
{
s_sQLServerVersion ??= GetSqlServerVersion(TCPConnectionString);
s_sQLServerVersion ??= GetSqlServerProperty(TCPConnectionString, "ProductMajorVersion");
}
return s_sQLServerVersion;
}
Expand Down Expand Up @@ -143,7 +165,6 @@ static DataTestUtility()
DNSCachingConnString = c.DNSCachingConnString;
DNSCachingServerCR = c.DNSCachingServerCR;
DNSCachingServerTR = c.DNSCachingServerTR;
IsAzureSynapse = c.IsAzureSynapse;
IsDNSCachingSupportedCR = c.IsDNSCachingSupportedCR;
IsDNSCachingSupportedTR = c.IsDNSCachingSupportedTR;
EnclaveAzureDatabaseConnString = c.EnclaveAzureDatabaseConnString;
Expand Down Expand Up @@ -272,19 +293,27 @@ private static string GenerateAccessToken(string authorityURL, string aADAuthUse

public static bool IsKerberosTest => !string.IsNullOrEmpty(KerberosDomainUser) && !string.IsNullOrEmpty(KerberosDomainPassword);

public static string GetSqlServerVersion(string connectionString)
public static string GetSqlServerProperty(string connectionString, string propertyName)
{
string version = string.Empty;
string propertyValue = string.Empty;
using SqlConnection conn = new(connectionString);
conn.Open();
SqlCommand command = conn.CreateCommand();
command.CommandText = "SELECT SERVERProperty('ProductMajorVersion')";
command.CommandText = $"SELECT SERVERProperty('{propertyName}')";
SqlDataReader reader = command.ExecuteReader();
if (reader.Read())
{
version = reader.GetString(0);
switch (propertyName)
{
case "EngineEdition":
propertyValue = reader.GetInt32(0).ToString();
break;
case "ProductMajorVersion":
propertyValue = reader.GetString(0);
break;
}
}
return version;
return propertyValue;
}

public static bool GetSQLServerStatusOnTDS8(string connectionString)
Expand Down