Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1.5] Fix | Invalid transaction exception against the connections and distributed transactions (#2301) #2321

Merged
merged 1 commit into from Jan 26, 2024

Conversation

JRahnama
Copy link
Member

Backport PR #2301 to 5.1.5
Unsubscribing from a transaction completion event before returning it to the pool is done to prevent potential signals from the previous state.

Fixes #1675

@JRahnama JRahnama added the 🐛 Bug! Something isn't right ! label Jan 25, 2024
@JRahnama JRahnama added this to In Progress in SqlClient v5.1.5 hotfix Jan 25, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/5.1@5cc6ca8). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/5.1    #2321   +/-   ##
==============================================
  Coverage               ?   71.25%           
==============================================
  Files                  ?      293           
  Lines                  ?    61554           
  Branches               ?        0           
==============================================
  Hits                   ?    43862           
  Misses                 ?    17692           
  Partials               ?        0           
Flag Coverage Δ
addons 92.38% <0.00%> (?)
netcore 76.05% <0.00%> (?)
netfx 68.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JRahnama JRahnama merged commit f8520c7 into dotnet:release/5.1 Jan 26, 2024
130 checks passed
SqlClient v5.1.5 hotfix automation moved this from In Progress to Done Jan 26, 2024
@JRahnama JRahnama deleted the backport-transaction branch March 8, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants