Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuspec on .net 6.0 #2317

Merged
merged 1 commit into from Jan 24, 2024
Merged

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Jan 24, 2024

Update to #2303 (noticed while browsing the 5.2 release notes)

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jan 24, 2024

@JRahnama FYI

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (838b931) 72.50% compared to head (389d27e) 72.45%.
Report is 3 commits behind head on main.

Files Patch % Lines
...osoft/Data/SqlClient/Server/ValueUtilsSmi.netfx.cs 0.00% 2 Missing ⚠️
...qlClient/src/Microsoft/Data/SqlClient/SqlBuffer.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   72.50%   72.45%   -0.05%     
==========================================
  Files         310      310              
  Lines       61872    61873       +1     
==========================================
- Hits        44858    44832      -26     
- Misses      17014    17041      +27     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.67% <66.66%> (-0.03%) ⬇️
netfx 69.86% <40.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JRahnama
Copy link
Member

Thank you @ErikEJ.

@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview5 milestone Jan 24, 2024
@DavoudEshtehari DavoudEshtehari changed the title Missed one :-( Update nuspec on .net 6.0 Jan 24, 2024
@DavoudEshtehari DavoudEshtehari merged commit 9347412 into dotnet:main Jan 24, 2024
148 checks passed
@ErikEJ ErikEJ deleted the missingdepends branch February 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants