Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | SQL auth method validation on debug #2288

Merged

Conversation

DavoudEshtehari
Copy link
Member

A minor fix over #2159 on debug mode.

@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview5 milestone Jan 8, 2024
@DavoudEshtehari DavoudEshtehari added this to In progress in SqlClient v5.2 via automation Jan 8, 2024
SqlClient v5.2 automation moved this from In progress to Reviewer approved Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f00e1c) 72.56% compared to head (ef754a8) 72.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2288      +/-   ##
==========================================
+ Coverage   72.56%   72.60%   +0.04%     
==========================================
  Files         310      310              
  Lines       62045    62045              
==========================================
+ Hits        45021    45048      +27     
+ Misses      17024    16997      -27     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.61% <ø> (-0.13%) ⬇️
netfx 70.07% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari merged commit 2e4d1b6 into dotnet:main Jan 9, 2024
148 checks passed
SqlClient v5.2 automation moved this from Reviewer approved to Done Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants