Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update | Adding ActiveDirectoryWorkloadIdentity to ref folder and soring the n… #2264

Conversation

JRahnama
Copy link
Member

@JRahnama JRahnama commented Dec 8, 2023

Adding to PR #2159

@JRahnama JRahnama added this to the 5.2.0-preview4 milestone Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d18e5c1) 72.51% compared to head (e773a96) 70.42%.

❗ Current head e773a96 differs from pull request most recent head 03f9af6. Consider uploading reports for the commit 03f9af6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2264      +/-   ##
==========================================
- Coverage   72.51%   70.42%   -2.09%     
==========================================
  Files         310      304       -6     
  Lines       62045    61736     -309     
==========================================
- Hits        44994    43480    -1514     
- Misses      17051    18256    +1205     
Flag Coverage Δ
addons ∅ <ø> (∅)
netcore 70.83% <ø> (-5.85%) ⬇️
netfx 70.02% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@H-Yeo H-Yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JRahnama JRahnama merged commit 923cad7 into dotnet:main Dec 8, 2023
5 of 147 checks passed
@JRahnama JRahnama deleted the Adding-ActiveDirectoryWorkloadIdentity-to-ref-folder branch May 6, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants