SqlBatch: Add missing overrides and tests

[Wraith2]

fixes #2222

Add missing overrides for SqlConnection CanCreateBatch and CreateDbBatch() and tests
Add test for SqlBatchCommand CanCreateParameter and CreateParameter() wrapped in #ifdef
Adding a net8 build is out of scope for this PR. That needs approval at very least from the MS side. When it is added the net8 features and tests related to the sql batch feature should light up automatically.

@David-Engel we'll want to get this in before the next preview.

/cc @mgravell

[roji]

@Wraith2 I think you also want to override the related methods missing on SqlClientFactory (here are the original specs):

public virtual DbBatch CreateBatch() => throw new NotSupportedException();
public virtual DbBatchCommand CreateBatchCommand() => throw new NotSupportedException();
    
// Covers both CreateBatch and CreateBatchCommand
public virtual bool CanCreateBatch => false;

[Wraith2]

Those are in a separate file:

SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientFactory.NetCoreApp.cs

Lines 9 to 18 in d30d9d1

	public sealed partial class SqlClientFactory : DbProviderFactory
	{
	/// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlClientFactory.xml' path='docs/members[@name="SqlClientFactory"]/CanCreateBatch/*'/>
	public override bool CanCreateBatch => true;
	/// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlClientFactory.xml' path='docs/members[@name="SqlClientFactory"]/CreateBatch/*'/>
	public override DbBatch CreateBatch() => new SqlBatch();
	/// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlClientFactory.xml' path='docs/members[@name="SqlClientFactory"]/CreateBatchCommand/*'/>
	public override DbBatchCommand CreateBatchCommand() => new SqlBatchCommand();

[roji]

My bad - I missed that when looking at the source code! Great that they're there.

[Wraith2]

They should light up as soon as the team add a net8 build.

[David-Engel]

Do these APIs need to be in the ref assemblies, too?

[Wraith2]

They're overrides so I wouldn't expect to see them in the ref assembly since they're defined on the base class and we didn't merge our own copies of the base classes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d30d9d1) 71.49% compared to head (6de6b91) 68.42%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2223      +/-   ##
==========================================
- Coverage   71.49%   68.42%   -3.08%     
==========================================
  Files         309      309              
  Lines       62181    62183       +2     
==========================================
- Hits        44459    42547    -1912     
- Misses      17722    19636    +1914     

Flag	Coverage Δ
addons	92.88% <ø> (ø)
netcore	66.24% <100.00%> (-8.32%)	⬇️
netfx	69.85% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.