Remove stale dependencies from SqlClient #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The System.Security.Cryptography.Cng and System.Security.Principal.Windows packages don't ship anymore since .NET 5 and are provided by the .NETCoreApp framework implicitly. Removing dependencies to those for .NETCoreApp TFMs to stop bringing these older versions in transitively. Fixes dotnet/runtime#93577
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 27 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
@Wraith2 any idea whom to ping to get this change merged in? |
|
Probably @David-Engel but things seem to be on hold at the moment to deal with internal issues. |
|
/azp run CI-SqlClient |
|
Azure Pipelines successfully started running 1 pipeline(s). |
David-Engel
approved these changes
Oct 19, 2023
DavoudEshtehari
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The System.Security.Cryptography.Cng and System.Security.Principal.Windows packages don't ship anymore since .NET 5 and are provided by the .NETCoreApp framework implicitly.
Removing dependencies to those for .NETCoreApp TFMs to stop bringing these older versions in transitively.
Fixes dotnet/runtime#93577