Enhance project and target files to generate debugging symbol package files #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRahnama
reviewed
Aug 25, 2023
… Directory.Build.props which is automatically imported.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2137 +/- ##
==========================================
- Coverage 72.50% 72.45% -0.05%
==========================================
Files 310 310
Lines 61872 61873 +1
==========================================
- Hits 44858 44829 -29
- Misses 17014 17044 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
David-Engel
reviewed
Aug 29, 2023
.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
DavoudEshtehari
changed the title
…AlwaysEncrypted.AzureKeyVaultProvider.csproj.
…exists in latest version.
…ps to Directory.Build.props as the projects fals to build in the pipeline.
Add commit id to nuget package to create.
…few minor issues. Upgrading Microsoft.SourceLink.GitHub to version 8.0.0
JRahnama
reviewed
Jan 18, 2024
Removing <IncludeSymbols>true</IncludeSymbols> and <SymbolPackageFormat>snupkg</SymbolPackageFormat> as we do it inside pack command. Adding extra line at the end of Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj
|
/azurepiplines run |
JRahnama
approved these changes
Jan 23, 2024
…ckageGeneration # Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
DavoudEshtehari
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more context:
when generating nuget with something similar to:
The command is designed to search for PDB files within the Nuspec. Consequently, PDBs should be incorporated into the file section, excluding the reference part. The inclusion of -Symbols -SymbolPackageFormat snupkg in the command ensures that these files are not copied to the lib folder of the NuGet.
To streamline our local builds, we have the option to skip the creation of the snupkg NuGet package and configure our pipeline to execute the appropriate command for this task.
links to support matterial:
https://learn.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg
https://devblogs.microsoft.com/dotnet/producing-packages-with-source-link/