Merge TDSParserStateObject.StateSnapshot state flags #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
|
@David-Engel can I get this reviewed? failures are just timed out legs. |
JRahnama
requested review from
David-Engel,
JRahnama,
DavoudEshtehari and
arellegue
|
Rebased to master and resolved merge conflicts with changes from #2144 |
David-Engel
approved these changes
Sep 13, 2023
|
@JRahnama, @DavoudEshtehari, @arellegue anyone got a 5 minutes for a quick review here? |
DavoudEshtehari
added
the
➕ Code Health
DavoudEshtehari
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly more complex because there are more call sites for this change. I recommend reviewing each single commit.
In netfx remove a bunch of state variables and replace them with SnapshottedStateFlags, move the get/set functions and the properties that use them to shared. Update the snapshot functions to use the state flags. Update uses of the state flags and finally move the now functionally identical function ResetSnapshotState to shared.