Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Health | Improve TdsParser #2071

Merged
merged 2 commits into from Jun 27, 2023

Conversation

DavoudEshtehari
Copy link
Member

  • plus code cleanup

@DavoudEshtehari DavoudEshtehari added the ➕ Code Health Changes related to source code improvements label Jun 23, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview3 milestone Jun 23, 2023
@DavoudEshtehari DavoudEshtehari added this to In progress in SqlClient v5.2 via automation Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 87.37% and project coverage change: -0.92 ⚠️

Comparison is base (2b31810) 70.79% compared to head (bafc8ae) 69.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
- Coverage   70.79%   69.87%   -0.92%     
==========================================
  Files         305      305              
  Lines       61819    61829      +10     
==========================================
- Hits        43764    43203     -561     
- Misses      18055    18626     +571     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.33% <97.87%> (-0.19%) ⬇️
netfx 68.12% <78.57%> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.91% <78.57%> (-0.34%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 68.24% <97.87%> (-0.35%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

SqlClient v5.2 automation moved this from In progress to Reviewer approved Jun 27, 2023
@DavoudEshtehari DavoudEshtehari merged commit 3ffc4f6 into dotnet:main Jun 27, 2023
132 checks passed
SqlClient v5.2 automation moved this from Reviewer approved to Done Jun 27, 2023
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Changes related to source code improvements
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants