Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev | Add support of the new authentication API with SSPI token on Managed SNI #2063

Merged
merged 8 commits into from Jun 29, 2023

Conversation

DavoudEshtehari
Copy link
Member

@DavoudEshtehari DavoudEshtehari commented Jun 15, 2023

@DavoudEshtehari DavoudEshtehari added netcore ➕ Code Health Changes related to source code improvements labels Jun 15, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview3 milestone Jun 15, 2023
@DavoudEshtehari DavoudEshtehari added this to In progress in SqlClient v5.2 via automation Jun 15, 2023
@DavoudEshtehari DavoudEshtehari added Ⓜ️ Managed SNI Use this label if the issue/PR relates to issues in Managed SNI and removed netcore labels Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 82.50% and project coverage change: -0.90 ⚠️

Comparison is base (2b31810) 70.80% compared to head (d361566) 69.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   70.80%   69.90%   -0.90%     
==========================================
  Files         305      305              
  Lines       61819    61943     +124     
==========================================
- Hits        43770    43303     -467     
- Misses      18049    18640     +591     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.37% <84.31%> (-0.16%) ⬇️
netfx 68.15% <80.00%> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...soft/Data/SqlClient/TdsParserStateObjectManaged.cs 79.72% <0.00%> (+0.55%) ⬆️
...t/src/Microsoft/Data/Common/AdapterUtil.Windows.cs 66.66% <ø> (ø)
.../Microsoft/Data/Common/DbConnectionStringCommon.cs 64.51% <ø> (ø)
...rc/Microsoft/Data/SqlClient/SqlConnectionString.cs 72.01% <0.00%> (-2.47%) ⬇️
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 96.25% <ø> (ø)
...tcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs 49.46% <25.00%> (ø)
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 68.33% <70.58%> (+0.18%) ⬆️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 73.69% <75.51%> (-0.01%) ⬇️
...SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs 68.50% <80.00%> (+0.25%) ⬆️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.94% <80.95%> (-0.30%) ⬇️
... and 11 more

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@David-Engel
Copy link
Contributor

@DavoudEshtehari This is great! Can we condition out the NET6-only files/classes/code related to the previous calls so that they aren't even compiled into the NET7+ binary?

@DavoudEshtehari DavoudEshtehari removed the ➕ Code Health Changes related to source code improvements label Jun 23, 2023
SqlClient v5.2 automation moved this from In progress to Reviewer approved Jun 29, 2023
@DavoudEshtehari DavoudEshtehari merged commit 6fbb337 into dotnet:main Jun 29, 2023
132 checks passed
SqlClient v5.2 automation moved this from Reviewer approved to Done Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ⓜ️ Managed SNI Use this label if the issue/PR relates to issues in Managed SNI
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants