Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Identity.Client package version #2031

Merged
merged 1 commit into from Jun 5, 2023

Conversation

azerios
Copy link
Contributor

@azerios azerios commented May 7, 2023

In order to fix High security issues present in the Veracode report my security team advise is to update this package in all nuget packages that my main solution reference

@azerios
Copy link
Contributor Author

azerios commented May 7, 2023

@dotnet-policy-service agree

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.78 ⚠️

Comparison is base (91694d8) 70.68% compared to head (0b5e4a6) 69.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
- Coverage   70.68%   69.91%   -0.78%     
==========================================
  Files         305      305              
  Lines       61795    61795              
==========================================
- Hits        43682    43204     -478     
- Misses      18113    18591     +478     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.43% <ø> (-0.03%) ⬇️
netfx 68.12% <ø> (-1.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JRahnama
Copy link
Member

JRahnama commented May 7, 2023

@azerios have you tried referencing the package version directly in your application? That will overwrite the original version. Version bumps without looking into the breaking changes may hurt lots of other applications.

@DavoudEshtehari DavoudEshtehari added this to In progress in SqlClient v5.2 via automation Jun 5, 2023
@DavoudEshtehari DavoudEshtehari added the 💡 Enhancement New feature request label Jun 5, 2023
SqlClient v5.2 automation moved this from In progress to Reviewer approved Jun 5, 2023
@DavoudEshtehari DavoudEshtehari changed the title Update of Microsoft.Identity.Client package Update Microsoft.Identity.Client package version Jun 5, 2023
@DavoudEshtehari DavoudEshtehari merged commit 9ec1f21 into dotnet:main Jun 5, 2023
132 checks passed
SqlClient v5.2 automation moved this from Reviewer approved to Done Jun 5, 2023
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement New feature request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants