Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Dropping reference to Microsoft.Win32.Registry in netcore. #1974

Merged
merged 5 commits into from Apr 3, 2023

Conversation

JRahnama
Copy link
Member

According to this announcement Microsoft.Win32.Registry is shipped with net 6 and after versions. Removing the reference in netcore csproj will eliminate the warning.

@ErikEJ
Copy link
Contributor

ErikEJ commented Mar 29, 2023

What does this fix?

@JRahnama
Copy link
Member Author

What does this fix?

Warnings on build time and also on Visual studio in referenced packages.

@David-Engel
Copy link
Contributor

@JRahnama
Make sure to run the ConnectionAliasTest test manually. It gets skipped in the pipeline since the agent doesn't have permission to create aliases.
image
Alternatively, you could refactor the pipeline and test to rely on a static alias that we set up at the beginning of the pipeline and define in the config.json.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (102ebb7) 70.48% compared to head (20e3860) 70.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
+ Coverage   70.48%   70.51%   +0.03%     
==========================================
  Files         306      306              
  Lines       61661    61661              
==========================================
+ Hits        43460    43482      +22     
+ Misses      18201    18179      -22     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.31% <ø> (-0.01%) ⬇️
netfx 69.10% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JRahnama
Copy link
Member Author

JRahnama commented Mar 30, 2023

@JRahnama Make sure to run the ConnectionAliasTest test manually. It gets skipped in the pipeline since the agent doesn't have permission to create aliases. image Alternatively, you could refactor the pipeline and test to rely on a static alias that we set up at the beginning of the pipeline and define in the config.json.

I did check the test. With modifying DataSource from localhost to FQDN and setting Encrypt to false it ran successfully.

Update: The change for the hostname was unnecessary and it worked fine with setting Encrypt = false only.

I will look into setting up the pipelines to be able to handle that test.

@JRahnama
Copy link
Member Author

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JRahnama
Copy link
Member Author

JRahnama commented Apr 2, 2023

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@David-Engel David-Engel merged commit 7550d41 into dotnet:main Apr 3, 2023
129 of 131 checks passed
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
@JRahnama JRahnama deleted the win32-registry-netcore branch September 8, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants