Fix NullReferenceException in GetBytesAsync #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 70.79% // Head: 69.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
- Coverage 70.79% 69.62% -1.17%
==========================================
Files 292 292
Lines 61732 61732
==========================================
- Hits 43701 42983 -718
- Misses 18031 18749 +718
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JRahnama
approved these changes
Jan 26, 2023
JRahnama
approved these changes
Jan 26, 2023
lcheunglci
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
LGTM, thanks @Wraith2 for the prompt fix. I tried to re-trigger the pipeline to run the tests a few times yesterday as I'm fairly sure the failures are not due to your changes.
lcheunglci
approved these changes
Jan 26, 2023
DavoudEshtehari
approved these changes
Jan 30, 2023
lcheunglci
pushed a commit
to lcheunglci/SqlClient
that referenced
this pull request
Mar 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1903
When calling GetBytesAsyns with no timeout no cancellation token source is created. The source value is captured by the async context and is being unconditionally disposed in DisposeCore(). This fix adds a null check before disposal.
Covering test is added.
/cc @NickKerensky