Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Add thread safety with transient error list on configurable retry logic #1882

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

DavoudEshtehari
Copy link
Member

Implementing the IEnumerable<T> doesn't guarantee thread safety, which would end to an inaccurate result under some circumstances.

  • This fix addresses intermittent failures on the pipeline with ConcurrentExecution test.

@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Something isn't right ! label Jan 9, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.1.0 milestone Jan 9, 2023
@DavoudEshtehari DavoudEshtehari added this to In Progress in SqlClient v5.1 via automation Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 70.66% // Head: 70.23% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (26d297a) compared to base (f046489).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
- Coverage   70.66%   70.23%   -0.44%     
==========================================
  Files         292      292              
  Lines       61728    61732       +4     
==========================================
- Hits        43619    43356     -263     
- Misses      18109    18376     +267     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.43% <100.00%> (-0.71%) ⬇️
netfx 69.09% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lClient/Reliability/SqlConfigurableRetryFactory.cs 100.00% <100.00%> (ø)
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 23.30% <0.00%> (-20.99%) ⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 44.64% <0.00%> (-7.15%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 66.11% <0.00%> (-0.78%) ⬇️
...nt/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs 48.90% <0.00%> (-0.63%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.63% <0.00%> (-0.59%) ⬇️
...ient/netfx/src/Microsoft/Data/SqlClient/SqlUtil.cs 57.38% <0.00%> (-0.25%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.37% <0.00%> (-0.11%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 73.64% <0.00%> (-0.10%) ⬇️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 73.54% <0.00%> (-0.07%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari changed the title Fix | Supports thread safety with transient error list on configurable retry logic Fix | Add thread safety with transient error list on configurable retry logic Jan 10, 2023
SqlClient v5.1 automation moved this from In Progress to Review Approved Jan 11, 2023
@DavoudEshtehari DavoudEshtehari merged commit c585669 into dotnet:main Jan 11, 2023
SqlClient v5.1 automation moved this from Review Approved to Done Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants