Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update native SNI version #1831

Merged

Conversation

DavoudEshtehari
Copy link
Member

Added complementary implementation for TLS 1.3.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 71.46% // Head: 71.38% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (246d06b) compared to base (760510c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
- Coverage   71.46%   71.38%   -0.09%     
==========================================
  Files         291      291              
  Lines       61304    61304              
==========================================
- Hits        43812    43761      -51     
- Misses      17492    17543      +51     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.95% <ø> (-0.10%) ⬇️
netfx 69.33% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-9.84%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 78.57% <0.00%> (-3.58%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.50% <0.00%> (-0.37%) ⬇️
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 95.91% <0.00%> (-0.35%) ⬇️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 73.16% <0.00%> (-0.33%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.50% <0.00%> (-0.30%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.37% <0.00%> (-0.13%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <0.00%> (+0.16%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

SqlClient v5.1 automation moved this from In Progress to Review Approved Nov 8, 2022
@DavoudEshtehari DavoudEshtehari merged commit f4568ce into dotnet:main Nov 8, 2022
SqlClient v5.1 automation moved this from Review Approved to Done Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants