Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Removing all net5 references from the driver #1823

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

JRahnama
Copy link
Member

@JRahnama JRahnama commented Nov 2, 2022

This PR simply removes all net5 references from the driver.

@JRahnama JRahnama added this to the 5.1.0-preview2 milestone Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 71.41% // Head: 71.39% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b606291) compared to base (146c34e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1823      +/-   ##
==========================================
- Coverage   71.41%   71.39%   -0.02%     
==========================================
  Files         290      290              
  Lines       61280    61280              
==========================================
- Hits        43761    43752       -9     
- Misses      17519    17528       +9     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.97% <ø> (-0.03%) ⬇️
netfx 69.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.77% <0.00%> (-4.92%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.71% <0.00%> (-0.09%) ⬇️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 83.49% <0.00%> (+0.07%) ⬆️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.65% <0.00%> (+0.07%) ⬆️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <0.00%> (+0.16%) ⬆️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 82.14% <0.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JRahnama JRahnama changed the title Removing all net5 references from the driver Test | Removing all net5 references from the driver Nov 2, 2022
@JRahnama JRahnama merged commit 708cf3a into dotnet:main Nov 2, 2022
@JRahnama JRahnama deleted the remove-net5 branch November 10, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants