TDS8 - Enable retrieval of TLS 1.3 SSL Protocol from SNI on .NET Core #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 71.38% // Head: 71.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
- Coverage 71.38% 71.34% -0.04%
==========================================
Files 290 290
Lines 61236 61251 +15
==========================================
- Hits 43712 43702 -10
- Misses 17524 17549 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Comment on lines
428
to
437
| * This driver does not support this version yet! */ | ||
| #if NETCOREAPP3_1_OR_GREATER | ||
| if (nativeProtocol.HasFlag(NativeProtocols.SP_PROT_TLS1_3_CLIENT) || nativeProtocol.HasFlag(NativeProtocols.SP_PROT_TLS1_3_SERVER)) | ||
| { | ||
| protocolVersion = (int)SslProtocols.Tls13; | ||
| }*/ | ||
| } | ||
| else if (nativeProtocol.HasFlag(NativeProtocols.SP_PROT_TLS1_2_CLIENT) || nativeProtocol.HasFlag(NativeProtocols.SP_PROT_TLS1_2_SERVER)) | ||
| #else | ||
| if (nativeProtocol.HasFlag(NativeProtocols.SP_PROT_TLS1_2_CLIENT) || nativeProtocol.HasFlag(NativeProtocols.SP_PROT_TLS1_2_SERVER)) | ||
| #endif |
There was a problem hiding this comment.
It's not required to be the first statement in the chain of if-else statements. This additional condition can be added as a else if just for simplification.
Also, the related inline comments won't be valid anymore.
JRahnama
reviewed
Oct 31, 2022
| @@ -425,12 +425,16 @@ internal override uint WaitForSSLHandShakeToComplete(out int protocolVersion) | |||
| var nativeProtocol = (NativeProtocols)nativeProtocolVersion; | |||
|
|
|||
| /* The SslProtocols.Tls13 is supported by netcoreapp3.1 and later | |||
| * This driver does not support this version yet! | |||
| * This driver does not support this version yet! */ | |||
| #if NETCOREAPP3_1_OR_GREATER | |||
There was a problem hiding this comment.
Since we are not supporting netcoreapp3.1 it should suffice if we just want to check for NETCOREAPP and omit the version.
Suggested change
| #if NETCOREAPP3_1_OR_GREATER | |
| #if NETCOREAPP |
DavoudEshtehari
approved these changes
Nov 1, 2022
JRahnama
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a timeout issue during
WaitForSSLHandShakeToCompletewhen I ran .NET Core with TLS 1.3 and noticed a commented-out section where it checks for TLS 1.3 and returningSslProtocols.None. However, I ran into a compile error when uncommenting a check for the ssl protocol while testing .NET Core with TLS1.3 when building the MDS project on .NET standard 2.1 becauseSslProtocols.Tls13does not exist. TheSslProtocols.Tls13does exist on .NET Core 3.1 and above, so I added anif-deffor it, so that I can get past the timeout issue where the retrieval of the protocol version occurs.