Port SqlParameter changes from netcore to netfx

[Wraith2]

Ports the changes in SqlParameters perf optimizations to netfx #209.
This is a prerequisite for #19

[JRahnama]

@Wraith2 Thanks for the PR. The test pipelines are setup, but there are some adjustments left to be done. I saw some failures on net462 and not sure if you were able to see them.

[Wraith2]

It turns out you have to actually set the parameters field so they can be sent to the server or all sorts of things stop working.

The CI doesn't seem happy because legs i haven't change (enclave ones) are failing for net6.0 builds. I'm also not sure which ones i should be paying attention to. Do we still have legacy checks?

[JRahnama]

It turns out you have to actually set the parameters field so they can be sent to the server or all sorts of things stop working.

The CI doesn't seem happy because legs i haven't change (enclave ones) are failing for net6.0 builds. I'm also not sure which ones i should be paying attention to. Do we still have legacy checks?

I will take the old one out today. The one I was working on, this will be primary one today, is CI-SqlClient-To-Be-Main.

[Wraith2]

Most legs are passing but some fail with EXEC(0)

[JRahnama]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[codecov]

Codecov Report

Base: 71.38% // Head: 71.39% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (27a369c) compared to base (20d4c19).
Patch coverage: 96.23% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
+ Coverage   71.38%   71.39%   +0.01%     
==========================================
  Files         290      290              
  Lines       61236    61265      +29     
==========================================
+ Hits        43712    43741      +29     
  Misses      17524    17524              

Flag	Coverage Δ
addons	92.38% <ø> (ø)
netcore	74.97% <100.00%> (-0.04%)	⬇️
netfx	69.32% <96.04%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...Microsoft/Data/SqlClient/TdsParserHelperClasses.cs	63.85% <88.88%> (+0.89%)	⬆️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs	73.16% <96.27%> (+0.59%)	⬆️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs	83.81% <100.00%> (+0.04%)	⬆️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	71.05% <100.00%> (+<0.01%)	⬆️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs	87.89% <0.00%> (-4.49%)	⬇️
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs	72.46% <0.00%> (-0.33%)	⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs	81.35% <0.00%> (-0.23%)	⬇️
...lient/src/Microsoft/Data/SqlClient/SqlParameter.cs	75.39% <0.00%> (-0.11%)	⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs	73.52% <0.00%> (-0.03%)	⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Wraith2]

Can you kick the CI again please.

[DavoudEshtehari]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Wraith2]

The failures are odd but appear repeatable. They're in Always Encrypted tests which i have no way to debug locally because of the sql server requirements. I'm going to need some help from the team to investigate why those failures are occuring.

As i mentioned in the first post this is a blocking issue for the sql batch api, without these changes there is no way to access the parameter collection for the set of rpc's in the batch.

[DavoudEshtehari]

The failures don't require Always Encrypted enabled.

[Wraith2]

Ok, all green now. quick merge it before I break it again!