Fixes ReadAsync() behavior to register Cancellation token action before streaming results #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
force-pushed
the
cheena/registerCancellationEarly
branch
from
6457e7e
to
632fa98
Compare
roji
reviewed
Sep 30, 2022
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDataReader.cs
Show resolved
Hide resolved
jnm2
reviewed
Sep 30, 2022
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderCancellationTest.cs
Show resolved
Hide resolved
jnm2
reviewed
Sep 30, 2022
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderCancellationTest.cs
Outdated
Show resolved
Hide resolved
|
/azurepipilines run |
cheenamalhotra
force-pushed
the
cheena/registerCancellationEarly
branch
from
e607d46
to
49440fa
Compare
cheenamalhotra
force-pushed
the
cheena/registerCancellationEarly
branch
from
51f50d9
to
e79cfa6
Compare
Codecov ReportBase: 71.47% // Head: 71.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 71.47% 71.43% -0.05%
==========================================
Files 293 293
Lines 61381 61381
==========================================
- Hits 43872 43846 -26
- Misses 17509 17535 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
David-Engel
approved these changes
Oct 4, 2022
|
@cheenamalhotra Please backport this to the 5.0.1 as well. Thanks! |
lcheunglci
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065 with test case added from comment.
cc @jnm2 @roji would appreciate some extra validations!