Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HostNameInCertificate property in NetFx Ref #1776

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 71.37% // Head: 71.40% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (3446ea7) compared to base (4dafe91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
+ Coverage   71.37%   71.40%   +0.02%     
==========================================
  Files         293      293              
  Lines       61376    61929     +553     
==========================================
+ Hits        43808    44219     +411     
- Misses      17568    17710     +142     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.97% <ø> (-0.02%) ⬇️
netfx 69.29% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/Data/ProviderBase/DbConnectionPool.NetCoreApp.cs 75.00% <0.00%> (-6.82%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 78.04% <0.00%> (-3.55%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <0.00%> (-0.48%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 72.88% <0.00%> (-0.40%) ⬇️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 72.02% <0.00%> (-0.17%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.50% <0.00%> (-0.08%) ⬇️
...ient/netfx/src/Microsoft/Data/SqlClient/SqlUtil.cs 58.29% <0.00%> (+0.24%) ⬆️
...Microsoft/Data/SqlClient/TdsParserStaticMethods.cs 73.33% <0.00%> (+1.11%) ⬆️
...osoft/Data/SqlClient/SqlConnectionStringBuilder.cs 90.00% <0.00%> (+1.41%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 27, 2022

I have seen this happen before with another new connection string property. Wonder if it would be possible to author a general test to prevent this from happening again?

@cheenamalhotra
Copy link
Member Author

Maybe time to revive #1307 and enable "Package" reference tests to be run once in a while..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlConnectionStringBuilder class missing HostNameInCertificate property
4 participants