For failed connection requests in ConnectionPool in case of PoolBlock…

[sorensenmatias]

For failed connection requests in ConnectionPool in case of PoolBlockingPeriod not enabled, ensure stacktrace of the exception is not swallowed.
Currently, the implementation passes the exception as a parameter and rethrows it, which creates a brand new stacktrace, and hides the original stacktrace of the failed connection attempt.
With this change, the original stacktrace is kept.

[dnfadmin]

All CLA requirements met.

[codecov]

Codecov Report

Base: 71.74% // Head: 71.32% // Decreases project coverage by -0.41% ⚠️

Coverage data is based on head (584b1b9) compared to base (7d348eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
- Coverage   71.74%   71.32%   -0.42%     
==========================================
  Files         293      293              
  Lines       61376    61374       -2     
==========================================
- Hits        44035    43776     -259     
- Misses      17341    17598     +257     

Flag	Coverage Δ
addons	92.38% <ø> (ø)
netcore	74.91% <100.00%> (-0.38%)	⬇️
netfx	69.19% <ø> (-0.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...t/Data/ProviderBase/DbConnectionPool.NetCoreApp.cs	75.00% <ø> (-6.82%)	⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs	85.19% <100.00%> (-0.65%)	⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs	56.81% <0.00%> (-18.19%)	⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs	78.57% <0.00%> (-17.86%)	⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs	30.35% <0.00%> (-11.61%)	⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs	59.25% <0.00%> (-4.24%)	⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs	17.04% <0.00%> (-3.41%)	⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs	81.58% <0.00%> (-1.89%)	⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs	81.65% <0.00%> (-1.33%)	⬇️
...core/src/Microsoft/Data/SqlClient/SqlConnection.cs	77.31% <0.00%> (-1.21%)	⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.