Fix | Default UTF8 collation conflict #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 71.50% // Head: 71.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
- Coverage 71.50% 71.41% -0.09%
==========================================
Files 293 293
Lines 61385 61376 -9
==========================================
- Hits 43892 43831 -61
- Misses 17493 17545 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lcheunglci
reviewed
Aug 30, 2022
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Utf8SupportTest/Utf8SupportTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/Utf8SupportTest/Utf8SupportTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Lawrence LCI <31262254+lcheunglci@users.noreply.github.com>
David-Engel
reviewed
Aug 30, 2022
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
lcheunglci
approved these changes
Aug 31, 2022
David-Engel
approved these changes
Aug 31, 2022
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Sep 1, 2022
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Sep 1, 2022
DavoudEshtehari
added a commit
that referenced
this pull request
Sep 8, 2022
DavoudEshtehari
added a commit
that referenced
this pull request
Sep 8, 2022
Kaur-Parminder
added a commit
to Kaur-Parminder/SqlClient
that referenced
this pull request
Jan 31, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Apr 11, 2023
# Conflicts: # src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
JRahnama
pushed a commit
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Defining a database with UTF8 collation overrides its column's collation with the same LCID.