Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port lazy initialize hidden column map to netfx #1443

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Dec 23, 2021

Ports the changes from #521 to netfx. Contributes to minimizing differences between the two codebases.

@JRahnama JRahnama added this to In Progress in SqlClient v5.1 via automation Aug 16, 2022
@JRahnama JRahnama added this to the 5.1.0-preview1 milestone Aug 16, 2022
@DavoudEshtehari DavoudEshtehari added netfx ➕ Code Health Changes related to source code improvements labels Sep 30, 2022
# Conflicts:
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 71.60% // Head: 71.46% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (e3834f7) compared to base (f62ac3b).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
- Coverage   71.60%   71.46%   -0.14%     
==========================================
  Files         293      293              
  Lines       61381    61396      +15     
==========================================
- Hits        43953    43879      -74     
- Misses      17428    17517      +89     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 75.02% <ø> (-0.26%) ⬇️
netfx 69.32% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 71.04% <ø> (+0.05%) ⬆️
...Microsoft/Data/SqlClient/TdsParserHelperClasses.cs 62.96% <67.50%> (+2.16%) ⬆️
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 68.42% <93.75%> (+0.01%) ⬆️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 41.96% <0.00%> (-18.75%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-4.92%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 78.57% <0.00%> (-3.58%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.65% <0.00%> (-1.70%) ⬇️
...soft/Data/SqlClient/TdsParserStateObjectManaged.cs 84.02% <0.00%> (-1.39%) ⬇️
...core/src/Microsoft/Data/SqlClient/SqlConnection.cs 77.31% <0.00%> (-1.21%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

SqlClient v5.1 automation moved this from In Progress to Review Approved Oct 4, 2022
@DavoudEshtehari DavoudEshtehari merged commit a4974d4 into dotnet:main Oct 5, 2022
SqlClient v5.1 automation moved this from Review Approved to Done Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Changes related to source code improvements netfx
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants