Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message in prepare-release when uncommited changes are present #885

Merged
merged 2 commits into from Jan 11, 2023

Conversation

clyvari
Copy link
Contributor

@clyvari clyvari commented Jan 10, 2023

Fixes #883

This PR simply changes text information presented to the user, so no tests were added / changed.

The documentation is also updated to mention that uncommitted changes are undesirable,

I appreciate any feedback, let me know if anything need to be changed.

@clyvari clyvari marked this pull request as draft January 10, 2023 22:56
@dnfadmin
Copy link

dnfadmin commented Jan 10, 2023

CLA assistant check
All CLA requirements met.

@clyvari clyvari marked this pull request as ready for review January 10, 2023 23:20
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Your doc and wording changes look like they'll really help clarify. Thank you.

@AArnott AArnott merged commit f1605ff into dotnet:main Jan 11, 2023
@AArnott AArnott added this to the v3.6 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepare-release command does nothing
3 participants