Fix CloudBuildAllVars value formatting #882
Merged
+19
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #876 (comment), the formatting of the
CloudBuildAllVars
values used the current culture and didn't specify a format for date values, causing the format to change based on the current culture and not be consistent (between systems/build servers).Although currently only the
GitCommitDate
value is affected, I've ensured the code also uses the invariant culture for other types (e.g. in case a decimal value is added in the future). I've also ignored theVersionOptions
property, since that isn't a simple value type and other complex values aren't outputted as well (likeBuildMetadataWithCommitId
andBuildMetadata
).Before this PR,
nbgv.exe get-version -f json
would output the following:With this PR applied, you'll notice the
NBGV_VersionOptions
is not present anymore andNBGV_GitCommitDate
contains an ISO 8601 date format: