Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of NBGV_SetMauiVersionProperties to suppress new behavior #860

Merged
merged 1 commit into from Nov 9, 2022

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Nov 9, 2022

Fixes issue @bakerhillpins brought up in #828 (comment)

@AArnott AArnott added this to the v3.6 milestone Nov 9, 2022
@AArnott AArnott disabled auto-merge November 9, 2022 21:00
@AArnott AArnott merged commit 6eddc9b into main Nov 9, 2022
@AArnott AArnott deleted the fix828 branch November 9, 2022 21:00
@bakerhillpins
Copy link

@AArnott This change allows the user to opt out of BOTH settings at once which is convenient when one is using central package management and they don't want to apply it to their EXE project.

It also appears that this feature is OFF by default as I don't see any change where NBGV_SetMauiVersionProperties is set to true. Thus users would need to Opt IN to version updates?
Was your plan to opt in or out? My thought would be that users would expect oping out.

@AArnott
Copy link
Collaborator Author

AArnott commented Nov 9, 2022

This is written to allow users to opt out. It remains on by default.
Note the check is that the new property not be false. No one sets it to false, so the condition is satisfied and the behavior is on. Opting out would look like this:

<NBGV_SetMauiVersionProperties>false</NBGV_SetMauiVersionProperties>

or

msbuild /p:NBGV_SetMauiVersionProperties=false

@bakerhillpins
Copy link

Thanks for the clarification and sorry about the confusion. I thought undefined properties evaluated false but I can't find the documentation concerning that. LOL

@AArnott
Copy link
Collaborator Author

AArnott commented Nov 9, 2022

msbuild properties are not boolean. They are all strings. They default to evaluating to the empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants