Enable nullability for BenchmarkDotNet.Annotations #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyAkinshin
requested changes
Aug 27, 2023
There was a problem hiding this comment.
Thanks for the PR! Changes in BenchmarkDotNet.Annotations look good. However, we should avoid custom changes in CodeAnnotations.cs since it prevents us from updating this file to the actual version. (Which is also a good thing to do. In Rider, the latest version can be obtained in Settings->Editor->Inspection Settings->Code Annotations->Copy C# implementation to clipboard).
|
So, you suggest updating this file to the last version and disabling nullability for it, right? Sounds like a great idea, I'll change it. |
AndreyAkinshin
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.